Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIG Apps spotlight #573

Merged
merged 6 commits into from
Mar 12, 2025
Merged

Add SIG Apps spotlight #573

merged 6 commits into from
Mar 12, 2025

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Feb 21, 2025

Add SIG Apps spotlight

Fixes: #521

/cc @sandipanpanda

@fsmunoz @sandipanpanda
Add SIG Apps spotlight.
bfa6f54 
Co-authored-by: Sandipan Panda <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2025
@sandipanpanda
Copy link
Member

@fsmunoz Thanks for driving this. Can we please have this x-posted in https://github.com/kubernetes/website/tree/main/content/en/blog/_posts as well?

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Feb 21, 2025

@fsmunoz Thanks for driving this. Can we please have this x-posted in https://github.com/kubernetes/website/tree/main/content/en/blog/_posts as well?

Of course, but I prefer to do it after a couple of days and removal of the WIP label, after incorporation of preliminary feedback like yours - less copying needed.

@sandipanpanda
Copy link
Member

Got it, thanks!

@sandipanpanda
Copy link
Member

sandipanpanda commented Feb 24, 2025 •
edited
Loading

https://deploy-preview-573--kubernetes-contributor.netlify.app/blog/2025/03/05/sig-apps-spotlight-2025/

/cc @sftim @reylejano @jberkus

@fsmunoz fsmunoz mentioned this pull request Feb 28, 2025
Merged
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Feb 28, 2025

/retitle Add SIG Apps spotlight

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Add SIG Apps spotlight. Add SIG Apps spotlight Feb 28, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@sandipanpanda
Copy link
Member

Overall LGTM, thanks!

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Mar 7, 2025

@reylejano all good comments, reflected in last commit

@reylejano
Copy link
Member

Thank you for addressing my comments
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2025
@jberkus
Copy link
Contributor

jberkus commented Mar 12, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 65a7eaa into kubernetes:master Mar 12, 2025
6 checks passed
@sandipanpanda sandipanpanda mentioned this pull request Mar 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reylejano reylejano reylejano left review comments

@sandipanpanda sandipanpanda sandipanpanda left review comments

@jberkus jberkus Awaiting requested review from jberkus

@sftim sftim Awaiting requested review from sftim

Assignees

@jberkus jberkus

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIG Apps Spotlight
5 participants
@fsmunoz @sandipanpanda @reylejano @jberkus @k8s-ci-robot